----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/#review68368 -----------------------------------------------------------
Mind adding another committer with more recent mock experience to this review? I suggest jcohen. src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py <https://reviews.apache.org/r/29901/#comment112554> unused import src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py <https://reviews.apache.org/r/29901/#comment112555> unused import src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py <https://reviews.apache.org/r/29901/#comment112559> spec_set=True. This lets the spec define the interface and prevents you from setting mock properties that don't exist on the spec like ```py mock_disk_collector.valu = 1234 ``` src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py <https://reviews.apache.org/r/29901/#comment112557> is the use of PropertyMock required here or can you do ```py mock_disk_collector.value = 4197 ``` same below src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py <https://reviews.apache.org/r/29901/#comment112556> Can you assert that the mocks are actually used below here (e.g. by checking expected calls were made)? A common issue with the client tests is the configuration of mocks that were later found to be unused. - Kevin Sweeney On Jan. 15, 2015, 4:11 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29901/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 4:11 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > De-flakify ResourceManager integration test. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/resource_manager.py > bf69e7e60ae4dd857243d8b040a70daca008ea28 > src/main/python/apache/thermos/monitoring/resource.py > 7b5bbe01810008c4d39b9dfee6521af01021a7ca > src/test/python/apache/aurora/executor/common/BUILD > 395ced27998def18eace2cbd46c736404c3d6411 > > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py > e3c766f9b7bf989c0790281231957947d2cda52a > > Diff: https://reviews.apache.org/r/29901/diff/ > > > Testing > ------- > > ./pants goal test --no-test-pytest-fast > src/test/python/apache/aurora/executor/common:: > > > Thanks, > > Brian Wickman > >
