> On Jan. 16, 2015, 12:27 a.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, > > line 17 > > <https://reviews.apache.org/r/29901/diff/3/?file=823232#file823232line17> > > > > unused import
killed > On Jan. 16, 2015, 12:27 a.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, > > line 22 > > <https://reviews.apache.org/r/29901/diff/3/?file=823232#file823232line22> > > > > unused import killed > On Jan. 16, 2015, 12:27 a.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, > > line 77 > > <https://reviews.apache.org/r/29901/diff/3/?file=823232#file823232line77> > > > > is the use of PropertyMock required here or can you do > > > > ```py > > mock_disk_collector.value = 4197 > > ``` > > > > same below it's required if we make mock_calls assertions - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/#review68368 ----------------------------------------------------------- On Jan. 16, 2015, 12:51 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29901/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 12:51 a.m.) > > > Review request for Aurora, Joshua Cohen and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > De-flakify ResourceManager integration test. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/resource_manager.py > bf69e7e60ae4dd857243d8b040a70daca008ea28 > src/main/python/apache/thermos/monitoring/resource.py > 7b5bbe01810008c4d39b9dfee6521af01021a7ca > src/test/python/apache/aurora/executor/common/BUILD > 395ced27998def18eace2cbd46c736404c3d6411 > > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py > e3c766f9b7bf989c0790281231957947d2cda52a > > Diff: https://reviews.apache.org/r/29901/diff/ > > > Testing > ------- > > ./pants goal test --no-test-pytest-fast > src/test/python/apache/aurora/executor/common:: > > > Thanks, > > Brian Wickman > >
