----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69573 -----------------------------------------------------------
This patch does not apply cleanly on master (7ba6226), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 25, 2015, 5:26 p.m., Florian Pfeiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30010/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 5:26 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-184 > https://issues.apache.org/jira/browse/AURORA-184 > > > Repository: aurora > > > Description > ------- > > [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints > > This is the first step for AURORA-184, that removes the default host&rack > limit constraints. > The second step that's still missing would be to add s.th. like > "--default-constraints" as start parameter to the scheduler. > > AURORA-174 could probably be closed with this?(since the rack limit > constraint can be configured in the .aurora file) > > I can't really estimate the effect of my changes in > StorageBackfillTest&SchedulerThriftInterfaceTest, please have a closer look > at the changes I did there. > > Since this is also my first code submit, comments about codestyle&other bad > habbits are very appreciated. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 01b03508afac37b5a8f0ec5c3da1460695e1ef59 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 > > Diff: https://reviews.apache.org/r/30010/diff/ > > > Testing > ------- > > Added test for ConfigurationManager.hasName > Added test testNoHostAndRackConstraintsAdded, that checks if the constraints > are present > Tested on vagrant devcluster to see if constraints are also gone in "real > life" > > > Thanks, > > Florian Pfeiffer > >
