> On Jan. 26, 2015, 11:19 nachm., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > line 413 > > <https://reviews.apache.org/r/30010/diff/6/?file=833613#file833613line413> > > > > s/public //
Feeling kind of stupid here, I somehow thought this had to be public so that I could use it in the ConfigurationManagerTest. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69688 ----------------------------------------------------------- On Jan. 27, 2015, 1:08 vorm., Florian Pfeiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30010/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 1:08 vorm.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-184 > https://issues.apache.org/jira/browse/AURORA-184 > > > Repository: aurora > > > Description > ------- > > [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints > > This is the first step for AURORA-184, that removes the default host&rack > limit constraints. > The second step that's still missing would be to add s.th. like > "--default-constraints" as start parameter to the scheduler. > > AURORA-174 could probably be closed with this?(since the rack limit > constraint can be configured in the .aurora file) > > I can't really estimate the effect of my changes in > StorageBackfillTest&SchedulerThriftInterfaceTest, please have a closer look > at the changes I did there. > > Since this is also my first code submit, comments about codestyle&other bad > habbits are very appreciated. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 5dfbcf1f6de716502a28f7da33a095968eb8420e > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 92ba45033ada8114349c435316c9681395aea706 > > Diff: https://reviews.apache.org/r/30010/diff/ > > > Testing > ------- > > Added test for ConfigurationManager.hasName > Added test testNoHostAndRackConstraintsAdded, that checks if the constraints > are present > Tested on vagrant devcluster to see if constraints are also gone in "real > life" > > > Thanks, > > Florian Pfeiffer > >