> On Jan. 26, 2015, 5:29 p.m., Dave Lester wrote: > > Were you able to test this patch on GitHub? I just tried applying this to > > my own GitHub account's Aurora repo > > (https://github.com/davelester/incubator-aurora) and used a second GH > > account to simulate this interaction, but never saw the prompt. Do you know > > if symlinks are supported here? Alternatively, we may want to move our > > existing contributions file to the root directory. > > Bill Farner wrote: > I'd also be okay with moving the file.
would you like me to update this review to just git mv the file or do you want to do it yourself? - Jeffrey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/#review69625 ----------------------------------------------------------- On Jan. 24, 2015, 9:53 p.m., Jeffrey Schroeder wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30249/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2015, 9:53 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Add CONTRIBUTING.md so github shows a link to it before opening a PR > > > Diffs > ----- > > CONTRIBUTING.md PRE-CREATION > > Diff: https://reviews.apache.org/r/30249/diff/ > > > Testing > ------- > > I accidentally opened a github pull request to fix a small documentation tyop > previously. Per the [github > documentation](https://github.com/blog/1184-contributing-guidelines), if you > have CONTRIBUTING.md in the root of the project, it will be shown before a > user ever opens a pull request. > > Probably makes sense to prevent people from opening pull requests in the > future. Note that this is simply a symlink to docs/contributing.md. > > > Thanks, > > Jeffrey Schroeder > >
