> On Jan. 26, 2015, 5:29 p.m., Dave Lester wrote:
> > Were you able to test this patch on GitHub? I just tried applying this to 
> > my own GitHub account's Aurora repo 
> > (https://github.com/davelester/incubator-aurora) and used a second GH 
> > account to simulate this interaction, but never saw the prompt. Do you know 
> > if symlinks are supported here? Alternatively, we may want to move our 
> > existing contributions file to the root directory.
> 
> Bill Farner wrote:
>     I'd also be okay with moving the file.
> 
> Jeffrey Schroeder wrote:
>     would you like me to update this review to just git mv the file or do you 
> want to do it yourself?
> 
> Bill Farner wrote:
>     Please update the review.  This sounds lazy, but it's helpful for our 
> stats if the commit goes in as you :-)

No I'd much prefer to get the review attributed to me, that is part of the draw 
of using git instead of svn (like zookeeper meh...). It is easier to do drive 
by fixes like this when I notice them and still get the credit.


- Jeffrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30249/#review69625
-----------------------------------------------------------


On Jan. 27, 2015, 4:27 a.m., Jeffrey Schroeder wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30249/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 4:27 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add CONTRIBUTING.md so github shows a link to it before opening a PR
> 
> 
> Diffs
> -----
> 
>   docs/README.md 4889b3ff208d56e3af34fdd876efaa7719e6504f 
>   docs/contributing.md  
> 
> Diff: https://reviews.apache.org/r/30249/diff/
> 
> 
> Testing
> -------
> 
> I accidentally opened a github pull request to fix a small documentation tyop 
> previously. Per the [github 
> documentation](https://github.com/blog/1184-contributing-guidelines), if you 
> have CONTRIBUTING.md in the root of the project, it will be shown before a 
> user ever opens a pull request.
> 
> Probably makes sense to prevent people from opening pull requests in the 
> future. Note that this is simply a symlink to docs/contributing.md.
> 
> 
> Thanks,
> 
> Jeffrey Schroeder
> 
>

Reply via email to