> On Jan. 29, 2015, 7:15 p.m., Zameer Manji wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 3116 > > <https://reviews.apache.org/r/30389/diff/1/?file=839596#file839596line3116> > > > > Why is this change necessary?
Thrift-generated code assumes collections are mutable, specifically in the `addTo*` methods. This is used in `ConfigurationManager`. > On Jan. 29, 2015, 7:15 p.m., Zameer Manji wrote: > > src/test/python/apache/aurora/client/cli/test_update.py, line 464 > > <https://reviews.apache.org/r/30389/diff/1/?file=839597#file839597line464> > > > > There has been some previous discussion that this style of test brittle > > and we should avoid it. Would you mind moving this test up to the > > "TestJobUpdateCommand" suite at the top of this file? > > > > This test could then be modified to have minimal patching. I had no idea there was a bifurcation of test approach in this file...wow. Moved. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/#review70248 ----------------------------------------------------------- On Jan. 29, 2015, 5:13 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30389/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 5:13 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-330 > https://issues.apache.org/jira/browse/AURORA-330 > > > Repository: aurora > > > Description > ------- > > Deny attempts to create a job update with a non-service job. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 8c19f3b08135eb5f3098591ebf9931b42a086318 > src/main/python/apache/aurora/client/cli/jobs.py > 7c5374417f8cca7400c7e92d014f706c0b2368fd > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 > src/test/python/apache/aurora/client/cli/test_update.py > c470ee64f11b5a1e4ce8cf1635c1acd2ec6e6e40 > src/test/python/apache/aurora/client/cli/util.py > 5b6207d45eba9ecc24cfd6dc5910677f9bc44372 > > Diff: https://reviews.apache.org/r/30389/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >