> On Jan. 29, 2015, 7:21 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, lines 738-741
> > <https://reviews.apache.org/r/30389/diff/1/?file=839595#file839595line738>
> >
> >     This is techincally not true for the client updater. Cron jobs are 
> > supported despite the fact that we now have cron commands to do so. I 
> > suggest narrowing down this validation to ad-hoc jobs only.

Good catch, modified this check.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70252
-----------------------------------------------------------


On Feb. 3, 2015, 11:53 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30389/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 11:53 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-330
>     https://issues.apache.org/jira/browse/AURORA-330
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deny attempts to create a job update with a non-service job.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8c19f3b08135eb5f3098591ebf9931b42a086318 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 7c5374417f8cca7400c7e92d014f706c0b2368fd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  03d1fba76c23570c2c4102a48daf5ce035ecaaa3 
>   src/test/python/apache/aurora/client/cli/test_inspect.py 
> ae04776fc32b2f09ce6303aeb893c60963896d60 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> c470ee64f11b5a1e4ce8cf1635c1acd2ec6e6e40 
>   src/test/python/apache/aurora/client/cli/util.py 
> 5b6207d45eba9ecc24cfd6dc5910677f9bc44372 
> 
> Diff: https://reviews.apache.org/r/30389/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to