----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70445 -----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java <https://reviews.apache.org/r/30471/#comment115632> Can you take a stab at serializing the thrift objec to a string and using that as your golden data to compare against? That would at least be resistant to refactors. - Bill Farner On Jan. 30, 2015, 11:24 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30471/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 11:24 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1076 > https://issues.apache.org/jira/browse/AURORA-1076 > > > Repository: aurora > > > Description > ------- > > The Docker patch (7ba6226) started to set the shell attribute of of > ExecutorInfo. This breaks backwards compatability for the GC executor as it > will > continue to have the same id but different info now. In addition it is not > necessary to set this value because it defaults to true. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java > d885b224ec5a1d529347d84e03ba98ab6734a126 > src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java > 876e173ccbac04e4a06a245648c7c6af15eaaa92 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30471/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > > Thanks, > > Zameer Manji > >
