-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/#review70456
-----------------------------------------------------------



src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java
<https://reviews.apache.org/r/30471/#comment115649>

    Consider 
[TextFormat.shortDebugString](https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/TextFormat.html#shortDebugString(com.google.protobuf.MessageOrBuilder))
 here instead.


- Kevin Sweeney


On Jan. 30, 2015, 3:54 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30471/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 3:54 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1076
>     https://issues.apache.org/jira/browse/AURORA-1076
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The Docker patch (7ba6226) started to set the shell attribute of of
> ExecutorInfo. This breaks backwards compatability for the GC executor as it 
> will
> continue to have the same id but different info now. In addition it is not
> necessary to set this value because it defaults to true.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
> d885b224ec5a1d529347d84e03ba98ab6734a126 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> 876e173ccbac04e4a06a245648c7c6af15eaaa92 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30471/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to