> On Feb. 3, 2015, 12:28 a.m., Bill Farner wrote:
> > src/main/python/apache/aurora/config/schema/base.py, line 35
> > <https://reviews.apache.org/r/30461/diff/2/?file=842715#file842715line35>
> >
> >     I think we should consider avoiding exposing this to end users.  This 
> > setting is really a behind-the-scenes timeout that they probably lack the 
> > context to set appropriately.

I take that back - this is a policy decision, and OSS end-users should have 
this knob.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review70662
-----------------------------------------------------------


On Jan. 30, 2015, 10:31 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30461/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 10:31 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
> 
> 
> Bugs: AURORA-1071
>     https://issues.apache.org/jira/browse/AURORA-1071
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Adding pulse_interval_secs into client UpdateConfig and validating its range
> - Raising an error in client updater for pulse_interval_secs
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/updater.py 
> 9f91de625f55514530a4f948d7ecdf7b5614b594 
>   src/main/python/apache/aurora/client/api/updater_util.py 
> 9d2e893a6ecff0fc48c7944575578443d41ced78 
>   src/main/python/apache/aurora/config/schema/base.py 
> e4433d2d47668f59bce169359131284d361bad09 
>   src/test/python/apache/aurora/client/api/test_api.py 
> ff1aff2eac391f219bc7c2483a16e35f916a224c 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> dd3f228c5062d388b4393aa4fd5b60a685bdb3a6 
>   src/test/python/apache/aurora/client/api/test_updater_util.py 
> fe3ac49491ca710761632405ac09de0cc0d038a5 
> 
> Diff: https://reviews.apache.org/r/30461/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python/apache/aurora/client::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to