> On Feb. 11, 2015, 2:23 a.m., Aurora ReviewBot wrote:
> > Master (64fa0ca) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                            self.expect_finish()
> >                            self.replay_mocks()
> >                          
> >                      >     self.update_and_expect_ok()
> >                      
> >                      
> > src/test/python/apache/aurora/client/api/test_updater.py:886: 
> >                      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> >                      
> > src/test/python/apache/aurora/client/api/test_updater.py:338: in 
> > update_and_expect_ok
> >                          
> > self.update_and_expect_response(ResponseCode.OK, instances)
> >                      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> >                      
> >                      self = <aurora.client.api.test_updater.UpdaterTest 
> > testMethod=test_update_instances_wait_for_batch_completion_filled_batch>
> >                      expected_code = 1, instances = None
> >                      message = None
> >                      
> >                          def update_and_expect_response(self, 
> > expected_code, instances=None, message=None):
> >                            resp = self._updater.update(instances)
> >                      >     assert expected_code == resp.responseCode, 
> > (
> >                              'Expected response:%s Actual response:%s' 
> > % (expected_code, resp.responseCode))
> >                      E     AssertionError: Expected response:1 
> > Actual response:2
> >                      E     assert 1 == 2
> >                      E      +  where 2 = 
> > Response(details=[ResponseDetail(message='Aborting update without rollback! 
> > Fa...n+ <UnorderedGroup "default">')], result=None, responseCode=2, 
> > serverInfo=None).responseCode
> >                      
> >                      
> > src/test/python/apache/aurora/client/api/test_updater.py:342: AssertionError
> >                       generated xml file: 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.api.updater.xml
> >  
> >                      ====== 1 failed, 31 passed in 1.16 seconds 
> > =======
> >                      src.test.python.apache.aurora.client.api.updater       
> >                          .....   FAILURE
> >                      src.test.python.apache.aurora.client.cli.config        
> >                          .....   SUCCESS
> >                      src.test.python.apache.aurora.client.cli.cron          
> >                          .....   SUCCESS
> >                      
> > src.test.python.apache.aurora.client.hooks.non_hooked_api                   
> >     .....   SUCCESS
> >                      
> > src.test.python.apache.aurora.common.test_http_signaler                     
> >     .....   SUCCESS
> >                      
> > src.test.python.apache.aurora.executor.common.path_detector                 
> >     .....   SUCCESS
> >                      
> > src.test.python.apache.aurora.executor.common.task_info                     
> >     .....   SUCCESS
> >                      src.test.python.apache.thermos.common.test_pathspec    
> >                          .....   SUCCESS
> >                      src.test.python.apache.thermos.monitoring.test_disk    
> >                          .....   SUCCESS
> >                      
> > FAILURE
> > 
> > 
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

Tests pass locally. @ReviewBot retry.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review71907
-----------------------------------------------------------


On Feb. 11, 2015, 1:19 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30461/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 1:19 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
> 
> 
> Bugs: AURORA-1071
>     https://issues.apache.org/jira/browse/AURORA-1071
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Adding pulse_interval_secs into client UpdateConfig and validating its range
> - Raising an error in client updater for pulse_interval_secs
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/updater.py 
> 9f91de625f55514530a4f948d7ecdf7b5614b594 
>   src/main/python/apache/aurora/client/api/updater_util.py 
> 9d2e893a6ecff0fc48c7944575578443d41ced78 
>   src/main/python/apache/aurora/config/schema/base.py 
> e4433d2d47668f59bce169359131284d361bad09 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> dd3f228c5062d388b4393aa4fd5b60a685bdb3a6 
>   src/test/python/apache/aurora/client/api/test_updater_util.py 
> fe3ac49491ca710761632405ac09de0cc0d038a5 
> 
> Diff: https://reviews.apache.org/r/30461/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python/apache/aurora/client::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to