----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30586/#review70851 -----------------------------------------------------------
src/test/python/apache/aurora/client/cli/test_cron.py <https://reviews.apache.org/r/30586/#comment116298> This seems like a copy/paste and should be redundant here and in other relevant test cases. src/test/python/apache/aurora/client/cli/test_cron.py <https://reviews.apache.org/r/30586/#comment116301> How about validating the option was actually used? There is another test `test_simple_successful_create_job_open_page` that you can model after. - Maxim Khutornenko On Feb. 3, 2015, 11:20 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30586/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 11:20 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1094 > https://issues.apache.org/jira/browse/AURORA-1094 > > > Repository: aurora > > > Description > ------- > > Fix exception when opening cron urls. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/cron.py > 3416c8e1932056725880f2007b60d77112759428 > src/test/python/apache/aurora/client/cli/test_cron.py > f488432cd68cc68fab8fce968e8605625ea3f56a > > Diff: https://reviews.apache.org/r/30586/diff/ > > > Testing > ------- > > ./pants goal test src/test/python/apache/aurora/client/cli:cron > > > Thanks, > > Zameer Manji > >
