> On Feb. 4, 2015, 1:47 a.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/cli/test_cron.py, line 138 > > <https://reviews.apache.org/r/30586/diff/2/?file=846914#file846914line138> > > > > You may want to drop unused CLUSTER patching in other tests as well. > > Zameer Manji wrote: > The other tests require the CLUSTER patching.
In their current shape of intergration tests punching through the API - they do. However, you can convert them to use fake api (similar to the test you added) and make them true unit tests. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30586/#review70895 ----------------------------------------------------------- On Feb. 4, 2015, 1:14 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30586/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 1:14 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1094 > https://issues.apache.org/jira/browse/AURORA-1094 > > > Repository: aurora > > > Description > ------- > > Fix exception when opening cron urls. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/cron.py > 3416c8e1932056725880f2007b60d77112759428 > src/test/python/apache/aurora/client/cli/test_cron.py > f488432cd68cc68fab8fce968e8605625ea3f56a > > Diff: https://reviews.apache.org/r/30586/diff/ > > > Testing > ------- > > ./pants goal test src/test/python/apache/aurora/client/cli:cron > > > Thanks, > > Zameer Manji > >
