> On Feb. 3, 2015, 4:05 p.m., Aurora ReviewBot wrote:
> > Master (2742120) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> >  (namespace package)
> >     
> >     Installing 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.util-0.3.0-py2.7-nspkg.pth
> >   Running setup.py install for twitter.common.collections
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> >  (namespace package)
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> >  (namespace package)
> >     
> >     Installing 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.collections-0.3.0-py2.7-nspkg.pth
> >   Running setup.py install for smmap
> >     
> >   Running setup.py install for twitter.common.string
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> >  (namespace package)
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> >  (namespace package)
> >     
> >     Installing 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.string-0.3.0-py2.7-nspkg.pth
> >   Running setup.py install for twitter.common.options
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> >  (namespace package)
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> >  (namespace package)
> >     
> >     Installing 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.options-0.3.0-py2.7-nspkg.pth
> >   Running setup.py install for twitter.common.dirutil
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> >  (namespace package)
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> >  (namespace package)
> >     
> >     Installing 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.dirutil-0.3.0-py2.7-nspkg.pth
> >   Running setup.py install for twitter.common.contextutil
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> >  (namespace package)
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> >  (namespace package)
> >     
> >     Installing 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.contextutil-0.3.0-py2.7-nspkg.pth
> >   Running setup.py install for twitter.common.lang
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> >  (namespace package)
> >     Skipping installation of 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> >  (namespace package)
> >     
> >     Installing 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.lang-0.3.0-py2.7-nspkg.pth
> > Successfully installed twitter.checkstyle pyflakes pep8 GitPython 
> > twitter.common.app gitdb twitter.common.process twitter.common.log 
> > twitter.common.util twitter.common.collections smmap twitter.common.string 
> > twitter.common.options twitter.common.dirutil twitter.common.contextutil 
> > twitter.common.lang
> > Cleaning up...
> > E501:ERROR   
> > src/test/python/apache/aurora/client/hooks/test_hooked_api.py:023 line too 
> > long (119 > 100 characters)
> >      |API_METHODS = ('cancel_update', 'create_job', 'kill_job', 'restart', 
> > 'start_cronjob', 'update_job', 'start_job_update')
> > 
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

George, can you fix the style issues?


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30585/#review70868
-----------------------------------------------------------


On Feb. 3, 2015, 3:58 p.m., George Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30585/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 3:58 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding command hook for beta-update start.
> 
> Also contains an update for the hooks documentation.
> 
> 
> Diffs
> -----
> 
>   docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> bc61e91af6de06ecfc37eddd846c096a5155d7eb 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 
> 
> Diff: https://reviews.apache.org/r/30585/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/hooks:hooked_api
> 
> 
> Thanks,
> 
> George Sirois
> 
>

Reply via email to