> On Feb. 4, 2015, 1:59 a.m., David McLaughlin wrote:
> > LGTM, thanks for the patch. 
> > 
> > Although I'm a little bit concerned about adding support for hooks in an 
> > environment where we can't support post-hooks.

Thanks!

I agree that it is certainly not ideal, but it does allow us to at least 
publish notifications when an update begins.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30585/#review70898
-----------------------------------------------------------


On Feb. 4, 2015, 12:24 a.m., George Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30585/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 12:24 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding command hook for beta-update start.
> 
> Also contains an update for the hooks documentation.
> 
> 
> Diffs
> -----
> 
>   docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> bc61e91af6de06ecfc37eddd846c096a5155d7eb 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 
> 
> Diff: https://reviews.apache.org/r/30585/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/hooks:hooked_api
> 
> 
> Thanks,
> 
> George Sirois
> 
>

Reply via email to