-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30818/#review71760
-----------------------------------------------------------
Master (68aa285) is red with this patch.
./build-support/jenkins/build.sh
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:jar
:assemble
:compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation
processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source
'1.7'
1 warning
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
Line is too long.
(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/controllers.js:340:102)
> var selectedTab = (length === JOB_CONTROLLER_PATH_MAX_PARTS ?
> pathParts[length - 1] : 'active');
Missing space after 'function'.
(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/controllers.js:345:37)
> $scope.pushTabState = function(tab) {
Missing semicolon.
(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/controllers.js:355:8)
> }
:jsHint FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':jsHint'.
> Process 'command '/home/jenkins/tools/java/jdk1.7.0_25-32/bin/java'' finished
> with non-zero exit value 2
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 33.219 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Feb. 10, 2015, 5:24 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30818/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 5:24 a.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Bugs: AURORA-696
> https://issues.apache.org/jira/browse/AURORA-696
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Previously navigating between the active/completed/all tabs on the
> job controller page did not alter the browser history. Now it does,
> meaning that you can navigate with the back button as well as link
> directly to a tab.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/job.html
> 4a00a8863d676f168fbfce9f45ec4bad0244199f
> src/main/resources/scheduler/assets/js/app.js
> b66409f628046c67b62c92a75cbeed20c09b4ec1
> src/main/resources/scheduler/assets/js/controllers.js
> 092e7d5df2121f45f99f5a788187d52bebb7e5dd
>
> Diff: https://reviews.apache.org/r/30818/diff/
>
>
> Testing
> -------
>
> ./gradlew jshint
>
> Verified push state worked in vagrant.
>
>
> Thanks,
>
> Joshua Cohen
>
>
