----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/#review71762 -----------------------------------------------------------
Master (68aa285) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 10, 2015, 6:01 a.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30818/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 6:01 a.m.) > > > Review request for Aurora and David McLaughlin. > > > Bugs: AURORA-696 > https://issues.apache.org/jira/browse/AURORA-696 > > > Repository: aurora > > > Description > ------- > > Previously navigating between the active/completed/all tabs on the > job controller page did not alter the browser history. Now it does, > meaning that you can navigate with the back button as well as link > directly to a tab. > > > Diffs > ----- > > src/main/resources/scheduler/assets/job.html > 4a00a8863d676f168fbfce9f45ec4bad0244199f > src/main/resources/scheduler/assets/js/app.js > b66409f628046c67b62c92a75cbeed20c09b4ec1 > src/main/resources/scheduler/assets/js/controllers.js > 092e7d5df2121f45f99f5a788187d52bebb7e5dd > > Diff: https://reviews.apache.org/r/30818/diff/ > > > Testing > ------- > > ./gradlew jsHint > > Verified push state worked in vagrant. > > > Thanks, > > Joshua Cohen > >
