> On Feb. 10, 2015, 7:28 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > lines 1609-1618 > > <https://reviews.apache.org/r/30325/diff/4/?file=859288#file859288line1609> > > > > I don't know how you feel about the need for a Supplier, but using > > Optional#or[1] here might read better? > > > > [1] > > http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/base/Optional.html#or(com.google.common.base.Supplier)
I feel like it will overcomplicate things for no good reason here. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review71840 ----------------------------------------------------------- On Feb. 10, 2015, 12:53 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30325/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 12:53 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. > > > Bugs: AURORA-1009 > https://issues.apache.org/jira/browse/AURORA-1009 > > > Repository: aurora > > > Description > ------- > > Implemented the `pulseJobUpdate` RPC. > > The RB is diffed against https://reviews.apache.org/r/30225/ > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > 4f603f9e7ed004e53937a45ea8edf7241e15f5cf > src/main/java/org/apache/aurora/auth/CapabilityValidator.java > 45ef643ebe57c1517cdae373574331ea302a8b74 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > fd4d6908fe7680808cfdee9e78c37506af280068 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > a9966a823e9616d0bf9bd19fd62e632d931ddf0a > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 4bf63921f8aa4be943b2b9a7b0be9fb33f7762db > > Diff: https://reviews.apache.org/r/30325/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
