> On Feb. 11, 2015, 11:44 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > lines 1596-1603 > > <https://reviews.apache.org/r/30325/diff/4/?file=859288#file859288line1596> > > > > It seems strange that the UPDATE_COORDINATOR can pulse the update but > > cannot take any other action on it. Maybe allow this role to perform all > > write actions on updates?
Thanks for reminding. I was going to address it separately. Created https://issues.apache.org/jira/browse/AURORA-1119 - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review72060 ----------------------------------------------------------- On Feb. 11, 2015, 11:35 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30325/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 11:35 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. > > > Bugs: AURORA-1009 > https://issues.apache.org/jira/browse/AURORA-1009 > > > Repository: aurora > > > Description > ------- > > Implemented the `pulseJobUpdate` RPC. > > The RB is diffed against https://reviews.apache.org/r/30225/ > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > cc2273025aa86ed17da691a143bb5b28226b124e > src/main/java/org/apache/aurora/auth/CapabilityValidator.java > 45ef643ebe57c1517cdae373574331ea302a8b74 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > fd4d6908fe7680808cfdee9e78c37506af280068 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > a9966a823e9616d0bf9bd19fd62e632d931ddf0a > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 4bf63921f8aa4be943b2b9a7b0be9fb33f7762db > > Diff: https://reviews.apache.org/r/30325/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
