> On Feb. 11, 2015, 11:59 p.m., David McLaughlin wrote:
> > FWIW I do agree with Bill's comment that minimum pulse time should be 
> > enforced in scheduler rather than here.

I am +1 on the scheduler check as complementary to the client when/if there is 
a need for it. I am -1 on using scheduler as the only source of truth here 
given the reasons I mentioned earlier.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review72068
-----------------------------------------------------------


On Feb. 11, 2015, 1:19 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30461/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 1:19 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
> 
> 
> Bugs: AURORA-1071
>     https://issues.apache.org/jira/browse/AURORA-1071
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Adding pulse_interval_secs into client UpdateConfig and validating its range
> - Raising an error in client updater for pulse_interval_secs
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/updater.py 
> 9f91de625f55514530a4f948d7ecdf7b5614b594 
>   src/main/python/apache/aurora/client/api/updater_util.py 
> 9d2e893a6ecff0fc48c7944575578443d41ced78 
>   src/main/python/apache/aurora/config/schema/base.py 
> e4433d2d47668f59bce169359131284d361bad09 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> dd3f228c5062d388b4393aa4fd5b60a685bdb3a6 
>   src/test/python/apache/aurora/client/api/test_updater_util.py 
> fe3ac49491ca710761632405ac09de0cc0d038a5 
> 
> Diff: https://reviews.apache.org/r/30461/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python/apache/aurora/client::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to