----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73642 -----------------------------------------------------------
src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java <https://reviews.apache.org/r/30895/#comment120039> This is bound to become a Texas constructor [1]. Please consider using the builder pattern instead to improve readability at the call sites. Brief docs on these would be helpful too. Specifically, `clusterUtilization` would benefit from a blurb. [1] https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/styleguide.md#stay-out-of-texas - Bill Farner On Feb. 23, 2015, 7:34 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30895/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 7:34 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Offer filtering for static vetoes. Part 4 of 4: Modifying benchmarks to > support preemption toggling. > > Original RB: https://reviews.apache.org/r/28617/ > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java > PRE-CREATION > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > bacfbfeb237ecddf82f58679e05be012c5214e61 > src/jmh/java/org/apache/aurora/benchmark/Tasks.java > 1a35f9ee9e8e76def0f9bf5454cf8cbdf6a89c25 > > Diff: https://reviews.apache.org/r/30895/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
