> On Feb. 23, 2015, 9:59 p.m., Bill Farner wrote: > > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 66 > > <https://reviews.apache.org/r/30895/diff/3/?file=873099#file873099line66> > > > > Javadoc here would be nice. I failed to elaborate on the last review, > > but it's not immediatly obvious what this value means.
My bad, forgot to address in the previous diff. Fixed now. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73680 ----------------------------------------------------------- On Feb. 23, 2015, 9:03 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30895/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 9:03 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Offer filtering for static vetoes. Part 4 of 4: Modifying benchmarks to > support preemption toggling. > > Original RB: https://reviews.apache.org/r/28617/ > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java > PRE-CREATION > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > bacfbfeb237ecddf82f58679e05be012c5214e61 > src/jmh/java/org/apache/aurora/benchmark/Tasks.java > 1a35f9ee9e8e76def0f9bf5454cf8cbdf6a89c25 > > Diff: https://reviews.apache.org/r/30895/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
