----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review73832 -----------------------------------------------------------
src/test/python/apache/aurora/common/test_clusters.py <https://reviews.apache.org/r/31350/#comment120234> How about populating with a real cluster here and asserting it later? src/test/python/apache/aurora/common/test_clusters.py <https://reviews.apache.org/r/31350/#comment120235> `with pytest.raises():` should be more compact. src/test/python/apache/aurora/common/test_clusters.py <https://reviews.apache.org/r/31350/#comment120237> Please, assert the entire contents here, e.g. `assert clusters == [Cluster(...)]` - Maxim Khutornenko On Feb. 24, 2015, 2:18 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31350/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 2:18 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Fix clusters.patch contextmanager cleanup > > Otherwise one failing testcase can affect the entire suite. > > > Diffs > ----- > > src/main/python/apache/aurora/common/clusters.py > c4b7fefca30313b281808478bf23158a9b7fbf85 > src/test/python/apache/aurora/common/test_clusters.py > 1bd696e9cd28d87d0cac68b33ab043407d796b61 > > Diff: https://reviews.apache.org/r/31350/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast src/test/python/apache/aurora/common:: > > > Thanks, > > Stephan Erb > >
