> On Feb. 24, 2015, 8:12 p.m., Kevin Sweeney wrote:
> > This is awesome! If this fixes the full suite, can you also remove 
> > `--no-fast` from `build-support/jenkins/build.sh`?

I doubt that this patch is sufficient to warrant the change of the build 
script. There may be many more error conditions requiring a `no-fast`.

Background info: We are directly using the python client in our own backend and 
are also writing some integration tests against it. In some of these testcases 
we are using CLUSTERS.patch and recently discovered its faulty cleanup 
behaviour.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73867
-----------------------------------------------------------


On Feb. 24, 2015, 10:52 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31350/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 10:52 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix clusters.patch contextmanager cleanup
> 
> Otherwise one failing testcase can affect the entire suite.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/clusters.py 
> c4b7fefca30313b281808478bf23158a9b7fbf85 
>   src/test/python/apache/aurora/common/test_clusters.py 
> 1bd696e9cd28d87d0cac68b33ab043407d796b61 
> 
> Diff: https://reviews.apache.org/r/31350/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/common::
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to