> On Feb. 25, 2015, 2:15 p.m., Joshua Cohen wrote: > > Is it worth adding test coverage for this shutdown ordering?
I don't think mock allows us to test for order. Steve can you take a quick look and tell us if it is possible? - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74104 ----------------------------------------------------------- On Feb. 25, 2015, 1:22 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31423/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 1:22 p.m.) > > > Review request for Aurora, Brian Wickman and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Stop the announcer and status checkers before starting to kill the runners. > > This allows the task to be removed from the ZK ensemble before it begins > getting killed. The delay can be significant if the task takes some time to > shutdown, and during the time it stops responding to requests. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/aurora_executor.py > 9c0282392dbb9cca308baf47adc1750c1f5cacc6 > > Diff: https://reviews.apache.org/r/31423/diff/ > > > Testing > ------- > > We're now running this in our production environments. Watching ZK, I can > confirm that the nodes are removed before process shutdown begins. Watching > the executor log also confirms this. > > I couldn't observe any other side effects either. > > > Thanks, > > Steve Niemitz > >
