-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74596
-----------------------------------------------------------
Master (e8a0a9f) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.factory
..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
..... SUCCESS
src.test.python.apache.aurora.common.test_clusters
..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler
..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version
..... SUCCESS
src.test.python.apache.aurora.common.test_shellify
..... SUCCESS
src.test.python.apache.aurora.common.test_transport
..... SUCCESS
src.test.python.apache.aurora.config.test_base
..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing
..... SUCCESS
src.test.python.apache.aurora.config.test_loader
..... SUCCESS
src.test.python.apache.aurora.config.test_thrift
..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer
..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout
..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
..... SUCCESS
src.test.python.apache.aurora.executor.common.kill_manager
..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info
..... SUCCESS
src.test.python.apache.aurora.executor.executor_base
..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars
..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor
..... SUCCESS
src.test.python.apache.aurora.executor.status_manager
..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor
..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
..... SUCCESS
src.test.python.apache.thermos.bin.test_thermos
..... FAILURE
src.test.python.apache.thermos.common.test_pathspec
..... SUCCESS
src.test.python.apache.thermos.core.test_process
..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration
..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Feb. 27, 2015, 8:58 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 8:58 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This splits src/main/python/apache/thermos/bin/thermos.py into
> src/main/python/apache/thermos/cli/**.
>
> This also adds a path detector registry (AURORA-1027) for the client so that
> we can easily add a customized aurora entry point for thermos that is capable
> of finding checkpoint roots in executor sandboxes. Added said entry point in
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where
> this should live (possibly under aurora/executor/bin?) This is a drop-in
> replacement for the existing thermos binary.
>
> The cli/commands/*.py are mostly no-op splits with only a few lines changed
> in gc, status and tail to get_path_detector.
>
> Added a basic testing framework and an example test for simplerun but did not
> go with full coverage, instead opting to ship AURORA-1027 for now.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/BUILD PRE-CREATION
> src/main/python/apache/aurora/tools/thermos.py PRE-CREATION
> src/main/python/apache/thermos/bin/BUILD
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26
> src/main/python/apache/thermos/bin/thermos.py
> 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/cli/BUILD PRE-CREATION
> src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION
> src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION
> src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION
> src/main/python/apache/thermos/cli/common.py PRE-CREATION
> src/main/python/apache/thermos/cli/main.py PRE-CREATION
> src/test/python/apache/thermos/cli/BUILD PRE-CREATION
> src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION
> src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION
> src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION
> src/test/python/apache/thermos/cli/test_common.py PRE-CREATION
> src/test/python/apache/thermos/cli/test_main.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31559/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/cli::
>
>
> Thanks,
>
> Brian Wickman
>
>
