-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74616
-----------------------------------------------------------
Master (388a5b3) is red with this patch.
./build-support/jenkins/build.sh
:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:jar
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java:865:
error: cannot find symbol
return expect(storageUtil.jobStore.fetchJob(anyObject(IJobKey.class)))
^
symbol: class IJobKey
location: class QuotaManagerImplTest
1 error
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 33.823 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Feb. 27, 2015, 10:48 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 10:48 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This splits src/main/python/apache/thermos/bin/thermos.py into
> src/main/python/apache/thermos/cli/**.
>
> This also adds a path detector registry (AURORA-1027) for the client so that
> we can easily add a customized aurora entry point for thermos that is capable
> of finding checkpoint roots in executor sandboxes. Added said entry point in
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where
> this should live (possibly under aurora/executor/bin?) This is a drop-in
> replacement for the existing thermos binary.
>
> The cli/commands/*.py are mostly no-op splits with only a few lines changed
> in gc, status and tail to get_path_detector.
>
> Added a basic testing framework and an example test for simplerun but did not
> go with full coverage, instead opting to ship AURORA-1027 for now.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/BUILD PRE-CREATION
> src/main/python/apache/aurora/tools/thermos.py PRE-CREATION
> src/main/python/apache/thermos/bin/BUILD
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26
> src/main/python/apache/thermos/bin/thermos.py
> 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/cli/BUILD PRE-CREATION
> src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION
> src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION
> src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION
> src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION
> src/main/python/apache/thermos/cli/common.py PRE-CREATION
> src/main/python/apache/thermos/cli/main.py PRE-CREATION
> src/test/python/apache/thermos/BUILD
> df50964851c6be89c646015edf91d07992743497
> src/test/python/apache/thermos/bin/BUILD
> 596aeb200dc55b077ed73fc342b9187045732890
> src/test/python/apache/thermos/bin/test_thermos.py
> 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/cli/BUILD PRE-CREATION
> src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION
> src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION
> src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION
> src/test/python/apache/thermos/cli/test_common.py PRE-CREATION
> src/test/python/apache/thermos/cli/test_main.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31559/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/cli::
>
>
> Thanks,
>
> Brian Wickman
>
>