> On March 4, 2015, 7:30 p.m., Kevin Sweeney wrote: > > Stephan: I'm ready to commit this but it looks like you don't have an email > > address in reviewboard. Can you set one so that we can attribute this patch > > and ping this review? > > > > ``` > > File > > "/Users/ksweeney/workspace/aurora/build-support/rbt.venv/lib/python2.7/site-packages/rbtools/clients/git.py", > > line 740, in create_commit > > '--author="%s <%s>"' % (author.fullname, author.email)]) > > File > > "/Users/ksweeney/workspace/aurora/build-support/rbt.venv/lib/python2.7/site-packages/rbtools/api/resource.py", > > line 299, in __getattr__ > > raise AttributeError > > AttributeError > > ```
It should now be public! - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review75203 ----------------------------------------------------------- On Feb. 24, 2015, 11:12 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31350/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 11:12 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Fix clusters.patch contextmanager cleanup > > Otherwise one failing testcase can affect the entire suite. > > > Diffs > ----- > > src/main/python/apache/aurora/common/clusters.py > c4b7fefca30313b281808478bf23158a9b7fbf85 > src/test/python/apache/aurora/common/test_clusters.py > 1bd696e9cd28d87d0cac68b33ab043407d796b61 > > Diff: https://reviews.apache.org/r/31350/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast src/test/python/apache/aurora/common:: > > > Thanks, > > Stephan Erb > >
