> On March 4, 2015, 7:18 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line 
> > 294
> > <https://reviews.apache.org/r/31754/diff/1/?file=885269#file885269line294>
> >
> >     ISTR this being necessary for static asset serving.  Is this no longer 
> > necesary just because of two ServletModules?

No longer needed - we now pass an instance of DefaultServlet to serve() instead 
with different init-params. Changed this elsewhere as well - we only need to 
bind the class form of a servlet or filter if it has an Inject-constructor.


> On March 4, 2015, 7:18 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java, 
> > line 107
> > <https://reviews.apache.org/r/31754/diff/1/?file=885273#file885273line107>
> >
> >     Do you think 'child module' is sufficiently descriptive?  It threw me 
> > off at first since parent/child already has a meaning in guice, so i 
> > thought there was some real black magic here.

It is actually a child module in the guice sense (it's a module used to seed 
the ServletContextListener's child injector). So there is some black magic.


> On March 4, 2015, 7:18 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/http/api/ApiTServletTest.java, 
> > lines 42-49
> > <https://reviews.apache.org/r/31754/diff/1/?file=885276#file885276line42>
> >
> >     I assume this is a demonstration of how servlet tests should look going 
> > forward - where they provide the specific bindings needed?  If so, i like 
> > it!

Yes, individual servlets can provide just their bindings (plus mock 
dependencies). This is the major purpose of this diff.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31754/#review75281
-----------------------------------------------------------


On March 4, 2015, 5:55 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31754/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 5:55 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Break out API servlet configuration into its own module.
> 
> This is necessary to make a follow-up patch introducing HTTP Basic auth 
> testable.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 8a59d89c07b406ce98076ca7ee51b958599a39ec 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerAPIServlet.java 
> 33ad43b3202e5e9ef5be919b6abc5cbc7f62b660 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java 
> d1ab9b18394ad37fe9dcb131816fcfb2952bf8b6 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> 80beb258d9f2786668d29db85b1295163a402d42 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 47d54e3c3bb1ba5e0fb26379792f515f25316480 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 5019094333f9807c64a49c29569ade191ee61824 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiTServletTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31754/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to