> On March 5, 2015, 10:40 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/SchedulerAPIServlet.java, 
> > line 25
> > <https://reviews.apache.org/r/31754/diff/1/?file=885270#file885270line25>
> >
> >     Any reason not to call this `ApiThriftServlet` to be more explicit?

Done. Also noticed the subclass was unnecessary - changed to Provider<TServlet>.


> On March 5, 2015, 10:40 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java, line 57
> > <https://reviews.apache.org/r/31754/diff/1/?file=885272#file885272line57>
> >
> >     one arg per line.

Fixed.


> On March 5, 2015, 10:40 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/app/AppModule.java, lines 66-81
> > <https://reviews.apache.org/r/31754/diff/1/?file=885268#file885268line66>
> >
> >     Is this import move correct? We should treat com.twitter just like any 
> > other com.* import, right?

fixed IDE settings.


> On March 5, 2015, 10:40 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line 
> > 44
> > <https://reviews.apache.org/r/31754/diff/1/?file=885269#file885269line44>
> >
> >     Same here re: import re-ordering.

same.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31754/#review75357
-----------------------------------------------------------


On March 4, 2015, 5:55 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31754/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 5:55 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Break out API servlet configuration into its own module.
> 
> This is necessary to make a follow-up patch introducing HTTP Basic auth 
> testable.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 8a59d89c07b406ce98076ca7ee51b958599a39ec 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerAPIServlet.java 
> 33ad43b3202e5e9ef5be919b6abc5cbc7f62b660 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java 
> d1ab9b18394ad37fe9dcb131816fcfb2952bf8b6 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> 80beb258d9f2786668d29db85b1295163a402d42 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 47d54e3c3bb1ba5e0fb26379792f515f25316480 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 5019094333f9807c64a49c29569ade191ee61824 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiTServletTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31754/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to