> On March 9, 2015, 11:27 a.m., Joshua Cohen wrote: > > Should we add tests for the full scheduler API as well as the admin > > interface? > > > > Also, worth adding a unit test for the interceptor?
Added ShiroThriftInterceptorTest. Not sure what you mean by test the full scheduler API - I check methods on ReadOnlyScheduler, AuroraSchedulerManager, and AuroraAdmin in the integration test. > On March 9, 2015, 11:27 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > line 41 > > <https://reviews.apache.org/r/31820/diff/1/?file=888081#file888081line41> > > > > Seems like most of our guice modules have javadoc. Mind adding one > > here? Or has our style changed in this regard w/ the switch to Google's > > checkstyle rules? Added. > On March 9, 2015, 11:27 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > line 50 > > <https://reviews.apache.org/r/31820/diff/1/?file=888081#file888081line50> > > > > @CanRead > > @Exists Implemented in an ArgParser. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75723 ----------------------------------------------------------- On March 6, 2015, 4:54 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31820/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 4:54 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-809 and AURORA-811 > https://issues.apache.org/jira/browse/AURORA-809 > https://issues.apache.org/jira/browse/AURORA-811 > > > Repository: aurora > > > Description > ------- > > * Add dependency on Apache Shiro. > * HTTP Basic Authentication. > * Authorization based on shiro.ini. > * Sample shiro.ini for local mode. > > > Diffs > ----- > > build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 24b61c1e4f615295acf28d904588e1512972d3f4 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 8a59d89c07b406ce98076ca7ee51b958599a39ec > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java > 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > 1e4ba014804b56a2ea02770d09beb63faaabf684 > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > 640acdf4e73f99418473ca97bcdc4f5f4c190f10 > > src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java > 52fe0ea063dbc7a71a20926630bf449dbd936306 > src/test/resources/org/apache/aurora/scheduler/app/local/shiro.ini > PRE-CREATION > > Diff: https://reviews.apache.org/r/31820/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > Local testing in the UI and with cURL. > > Updates to e2e test and Vagrant environment to follow. > > > Thanks, > > Kevin Sweeney > >
