----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75827 -----------------------------------------------------------
Master (e55113d) is red with this patch. ./build-support/jenkins/build.sh :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJava Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-guice/1.2.3/shiro-guice-1.2.3.pom Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-root/1.2.3/shiro-root-1.2.3.pom Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-web/1.2.3/shiro-web-1.2.3.pom Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-core/1.2.3/shiro-core-1.2.3.pom Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-guice/1.2.3/shiro-guice-1.2.3.jar Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-web/1.2.3/shiro-web-1.2.3.jar Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-core/1.2.3/shiro-core-1.2.3.jar Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :assemble :compileJmhJava :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java:1: Line does not match expected header line of '^\/\*\*$'. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java:1: Line does not match expected header line of '^\/\*\*$'. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java:23: Line is longer than 100 characters (found 101). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java:63:37: 'subjectProvider' hides a field. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. > Checkstyle rule violations were found. See the report at: > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 48.698 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 10, 2015, 12:37 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31820/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 12:37 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-809 and AURORA-811 > https://issues.apache.org/jira/browse/AURORA-809 > https://issues.apache.org/jira/browse/AURORA-811 > > > Repository: aurora > > > Description > ------- > > * Add dependency on Apache Shiro. > * HTTP Basic Authentication. > * Authorization based on shiro.ini. > * Sample shiro.ini for local mode. > > > Diffs > ----- > > build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 24b61c1e4f615295acf28d904588e1512972d3f4 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 8a59d89c07b406ce98076ca7ee51b958599a39ec > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java > 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > 1e4ba014804b56a2ea02770d09beb63faaabf684 > src/main/python/apache/aurora/common/clusters.py > c4b7fefca30313b281808478bf23158a9b7fbf85 > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > 640acdf4e73f99418473ca97bcdc4f5f4c190f10 > > src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java > 52fe0ea063dbc7a71a20926630bf449dbd936306 > src/test/python/apache/aurora/common/test_clusters.py > 1bd696e9cd28d87d0cac68b33ab043407d796b61 > > src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini > PRE-CREATION > > Diff: https://reviews.apache.org/r/31820/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > Local testing in the UI and with cURL. > > Updates to e2e test and Vagrant environment to follow. > > > Thanks, > > Kevin Sweeney > >
