-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32012/#review76320
-----------------------------------------------------------
Master (ee1a13a) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
..... SUCCESS
src.test.python.apache.aurora.common.test_clusters
..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler
..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version
..... SUCCESS
src.test.python.apache.aurora.common.test_shellify
..... SUCCESS
src.test.python.apache.aurora.common.test_transport
..... SUCCESS
src.test.python.apache.aurora.config.test_base
..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing
..... SUCCESS
src.test.python.apache.aurora.config.test_loader
..... SUCCESS
src.test.python.apache.aurora.config.test_thrift
..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer
..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout
..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
..... SUCCESS
src.test.python.apache.aurora.executor.common.kill_manager
..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info
..... SUCCESS
src.test.python.apache.aurora.executor.executor_base
..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars
..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor
..... SUCCESS
src.test.python.apache.aurora.executor.status_manager
..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor
..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
..... SUCCESS
src.test.python.apache.thermos.cli.commands.commands
..... SUCCESS
src.test.python.apache.thermos.cli.common
..... SUCCESS
src.test.python.apache.thermos.cli.main
..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec
..... SUCCESS
src.test.python.apache.thermos.core.test_process
..... FAILURE
src.test.python.apache.thermos.core.test_runner_integration
..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On March 13, 2015, 12:47 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32012/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 12:47 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We found that the new observer burns 10x the cpu in production. Most of the
> time is spent in compiling new regular expressions, so memoize them.
> Follow-up review adds TaskDetector caching in observer.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/common/path.py
> 4359a5143551fff3cf66e39e68ba9ba02b8d6e2e
> src/main/python/apache/thermos/monitoring/detector.py
> e0922e61ef03fc578988f992aba46570ea1b5d6c
> src/test/python/apache/thermos/monitoring/BUILD
> 4e99da403f322940579fd4f9412e022df0790884
> src/test/python/apache/thermos/monitoring/test_detector.py
> e9005c402ec81bbb415d9c814aa7b4e759138304
>
> Diff: https://reviews.apache.org/r/32012/diff/
>
>
> Testing
> -------
>
> Added generic TaskDetector test and made sure it passes before/after.
>
>
> Thanks,
>
> Brian Wickman
>
>
