----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76623 -----------------------------------------------------------
Ship it! Master (e11ed5b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 13, 2015, 7:38 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32012/ > ----------------------------------------------------------- > > (Updated March 13, 2015, 7:38 p.m.) > > > Review request for Aurora, Joe Smith and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > We found that the new observer burns 10x the cpu in production. Most of the > time is spent in compiling new regular expressions, so memoize them. > Follow-up review adds TaskDetector caching in observer. > > > Diffs > ----- > > src/main/python/apache/thermos/common/path.py > 4359a5143551fff3cf66e39e68ba9ba02b8d6e2e > src/main/python/apache/thermos/monitoring/detector.py > e0922e61ef03fc578988f992aba46570ea1b5d6c > src/test/python/apache/thermos/core/test_process.py > e261249b977802851ffc3d89437761c532fcd3f8 > src/test/python/apache/thermos/monitoring/BUILD > 4e99da403f322940579fd4f9412e022df0790884 > src/test/python/apache/thermos/monitoring/test_detector.py > e9005c402ec81bbb415d9c814aa7b4e759138304 > > Diff: https://reviews.apache.org/r/32012/diff/ > > > Testing > ------- > > Added generic TaskDetector test and made sure it passes before/after. > > > Thanks, > > Brian Wickman > >
