----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32181/#review76839 -----------------------------------------------------------
Ship it! Master (a419863) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 17, 2015, 10:50 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32181/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 10:50 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Only warn about insufficient GC resources when actually needed > > Whenever a garbage collection run finishes, the launcher is offered the same > resources again. Probably due to rounding errors, these are not considered > sufficient for another run. By changing the order of time check and resource > check we prevent unnecessary warnings about these small offers. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java > 31aa2bbaab3d97875493ad75c4d2c7c82ac7fa58 > src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java > 422d5a9a42310979752eb7282658316c2b772419 > > Diff: https://reviews.apache.org/r/32181/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
