> On March 17, 2015, 11:12 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java, 
> > line 208
> > <https://reviews.apache.org/r/32181/diff/1/?file=898407#file898407line208>
> >
> >     This reordering will result in pulsing the hostname even when an offer 
> > is insufficient for GC thus leading to missed collections. I'd much rather 
> > suppress the warning (e.g. change it to Level.FINE) than risk a missed 
> > collection.
> 
> Stephan Erb wrote:
>     What about extracting the pulsing from `isTimeToCollect` and performing 
> it directly in `willUse`?

Given this feature is going away soon, I'd rather not invest any time in 
improving it unless absolutely necessary. Are there any other concerns besides 
warnings in scheduler log? If not, perhaps lowering the logging level is the 
way to go.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32181/#review76841
-----------------------------------------------------------


On March 17, 2015, 10:50 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32181/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 10:50 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Only warn about insufficient GC resources when actually needed
> 
> Whenever a garbage collection run finishes, the launcher is offered the same 
> resources again. Probably due to rounding errors, these are not considered 
> sufficient for another run. By changing the order of time check and resource 
> check we prevent unnecessary warnings about these small offers.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> 31aa2bbaab3d97875493ad75c4d2c7c82ac7fa58 
>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
> 422d5a9a42310979752eb7282658316c2b772419 
> 
> Diff: https://reviews.apache.org/r/32181/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to