----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32231/#review77005 -----------------------------------------------------------
Master (6396410) is red with this patch. ./build-support/jenkins/build.sh :api:processResources UP-TO-DATE :api:classes :api:jar :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :startScripts :distTar :distZip :assemble :compileJmhJava :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:70: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:245:7: 'if' is not followed by whitespace. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:247:92: '+' should be on a new line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:248:17: '+' should be on a new line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:249:17: '+' should be on a new line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:250:83: '+' should be on a new line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:251:67: '+' should be on a new line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:252:17: '+' should be on a new line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:253:17: '+' should be on a new line. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. > Checkstyle rule violations were found. See the report at: > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 34.294 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 19, 2015, 3:21 a.m., Florian Pfeiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32231/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 3:21 a.m.) > > > Review request for Aurora. > > > Bugs: AURORA-1189 > https://issues.apache.org/jira/browse/AURORA-1189 > > > Repository: aurora > > > Description > ------- > > AURORA-1189: Adding check to see if java version is below 1.8 > > I think it should be fine to check the java version that naive (comparing the > char at 3rd posion of java.version) since this check will probably already be > removed again until java 1.10 comes out. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 66fb432028c26ea9ed8da475da6c3cbee5e535fc > > Diff: https://reviews.apache.org/r/32231/diff/ > > > Testing > ------- > > * ./gradlew test > * running scheduler on vagrant machine to check if log message appears > * couldn't get the scheduler run properly on java 1.8 to check if the message > doesn't appear there > > > Thanks, > > Florian Pfeiffer > >
