----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32231/#review77008 -----------------------------------------------------------
Master (6396410) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 19, 2015, 3:46 a.m., Florian Pfeiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32231/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 3:46 a.m.) > > > Review request for Aurora. > > > Bugs: AURORA-1189 > https://issues.apache.org/jira/browse/AURORA-1189 > > > Repository: aurora > > > Description > ------- > > AURORA-1189: Adding check to see if java version is below 1.8 > > I think it should be fine to check the java version that naive (comparing the > char at 3rd posion of java.version) since this check will probably already be > removed again until java 1.10 comes out. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 66fb432028c26ea9ed8da475da6c3cbee5e535fc > > Diff: https://reviews.apache.org/r/32231/diff/ > > > Testing > ------- > > * ./gradlew test > * running scheduler on vagrant machine to check if log message appears > * couldn't get the scheduler run properly on java 1.8 to check if the message > doesn't appear there > > > Thanks, > > Florian Pfeiffer > >
