Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/48
thanks @ire7715 -- I have a few remarks regarding your latest comment:
---
> Don't know if the force push would bother you when reviewing
Thanks for not force-pushing :+1: -- It's preferable to have multiple
commits in response to PR review comments and change requests. This makes it
much easier to come back later to see how code changes came about. Bahir
committers will squash all commits when merging Pull Requests.
So, please push another "normal" commit with your latest changes.
---
> `SparkGCPCredentialsBuilderSuite` ... ignores the test cases if the key
files or email account [environment variables] are not set (or file doesn't
exist) and shows the hint message
I agree mostly. We should ignore the test cases if env variables are not
set. However, if the environment variables **are set** and the key file **path
is invalid** then that should be an **error**. Otherwise we may not catch
problems if there are changes in the Jenkins CI server.
Could you generate a set of (permanent) key files which we can integrate
into our Jenkins PR builder?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
