Github user ire7715 commented on the issue:
https://github.com/apache/bahir/pull/48
Thanks @ckadner for reviewing ð
### Re: not-force pushing
Since it is preferable to push changes as other commit, and the PR will be
squashed when merging. I had recovered the origin commits, and made the last
changes as new commits (including
[f538342](https://github.com/apache/bahir/pull/48/commits/f5383429de100c3edbb4ccd58602f3d088fceed8),
[a5fd1a3](https://github.com/apache/bahir/pull/48/commits/a5fd1a314b5eec6313f2aa42648849536959db0f)
and
[efc0cdd](https://github.com/apache/bahir/pull/48/commits/efc0cdde76edfb11ab595ce0098a159612ef35dc)).
### Re: Invalid paths suppose to be an error not an ignorant
You are right, didn't think about it. I made the test case do not check if
the file existence anymore, and instead let the `ServiceAccountCredentials`
check the file existence at construction. If the file is not existed, just
raise a FileNotFoundException.
### Generate a key file for Jenkins PR builder
I would love to do it! But it might be a little absurd. Here is my points:
1. There is `org.apache.spark.streaming.pubsub.PubsubTestUtils` which
already uses environment variables to get the GCP project and json/p12 key
files. I guess there is a set of key files are set on the Jenkins server
already? Or the origin PubsubTestUtils didn't turned on by the environment
variable `ENABLE_PUBSUB_TESTS`?
2. I might be the wrong person to generate the key files. Since I am not a
member in the project, if I generated the key files today, and somehow someday
I accidentally deleted the key file (or my Google account just got banned). The
key would be no use at all, and it could be hard for you to contact me. Maybe
there is a Google account for this Jenkins server, that you may generate the
key file with it?
If I misunderstand you or there is anything wrong please tell me.
#### To generate a service account key file
1. Go to [Google API Console](console.developers.google.com)
2. Choose the `Credentials` Tab> `Create credentials` button> `Service
account key`
3. Fill the form to create one. I did twice, one for JSON key file, another
for P12.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
