sebastianliu commented on a change in pull request #82:
URL: https://github.com/apache/bahir-flink/pull/82#discussion_r442755855
##########
File path:
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/KuduTableFactory.java
##########
@@ -65,6 +65,7 @@
public static final String KUDU_HASH_COLS = "kudu.hash-columns";
public static final String KUDU_PRIMARY_KEY_COLS =
"kudu.primary-key-columns";
public static final String KUDU_REPLICAS = "kudu.replicas";
+ public static final String KUDU_IS_BOUNDED = "kudu.is-bounded";
Review comment:
For the `is-bounded` flag, it really just control the `isBounded()`
method in
`KuduTableSource` which inherit from `StreamTableSource`. The main reason I
add this is because there may be some users who want to use this kudu connector
in a Flink Batch SQL job. And this is usually used under the Blink Batch mode.
I also added a few notes to the README file. In addition, I keep the default
behavior of this `is-bounded` flag, which is false in `StreamTableSource`. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
