gyfora commented on pull request #82: URL: https://github.com/apache/bahir-flink/pull/82#issuecomment-647410546
> > I had a few minor comments but it looks pretty good in general. > > I also commented already on the is-bounded question, I think we should remove that logic from this PR as it does not introduce new functionality or change anything at the moment. > > @gyfora Hi Gyula, very appreciate for your code review. And for the `is-bounded` comment, I answered some of my ideas, but I didn't resolve it. Looking forward to the further discussion and review. Thx again :) As far as I understand the logic on the Flink side, the is-bounded flag does not affect the streaming execution and it should represent the actual source implementation. The Kudu table source is always bounded right now. Therefore we should always return isBounded = true and not expose any options to change this as that might lead to incorrect/unexpected behavior. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
