gyfora commented on a change in pull request #109:
URL: https://github.com/apache/bahir-flink/pull/109#discussion_r601169641
##########
File path:
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/writer/KuduWriterConfig.java
##########
@@ -65,6 +101,11 @@ public String toString() {
public static class Builder {
private String masters;
private FlushMode flushMode = FlushMode.AUTO_FLUSH_BACKGROUND;
+ private long timeout = 30000;
+ private int maxBufferSize = 1000;
+ private int flushInterval = 1000;
Review comment:
Where did you take this defaults from? How will this affect the out of
the box performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
