eskabetxe commented on a change in pull request #109:
URL: https://github.com/apache/bahir-flink/pull/109#discussion_r604290992
##########
File path:
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/writer/KuduWriterConfig.java
##########
@@ -65,6 +101,16 @@ public String toString() {
public static class Builder {
private String masters;
private FlushMode flushMode = FlushMode.AUTO_FLUSH_BACKGROUND;
+ // Reference from AsyncKuduClientBuilder defaultOperationTimeoutMs.
+ private long timeout = 30000;
Review comment:
could we use AsyncKuduClientBuilder.DEFAULT_OPERATION_TIMEOUT_MS
directly?
private long timeout = AsyncKuduClientBuilder.DEFAULT_OPERATION_TIMEOUT_MS;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
