jiajunwang commented on a change in pull request #510: Fixing rebalance cache
issue and stablize the tests.
URL: https://github.com/apache/helix/pull/510#discussion_r334670299
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/StrictMatchExternalViewVerifier.java
##########
@@ -56,19 +55,34 @@
private final Set<String> _resources;
private final Set<String> _expectLiveInstances;
+ private final boolean _isDeactivatedNodeAware;
+ @Deprecated
public StrictMatchExternalViewVerifier(String zkAddr, String clusterName,
Set<String> resources,
Set<String> expectLiveInstances) {
+ this(zkAddr, clusterName, resources, expectLiveInstances, false);
+ }
+
+ @Deprecated
+ public StrictMatchExternalViewVerifier(HelixZkClient zkClient, String
clusterName,
+ Set<String> resources, Set<String> expectLiveInstances) {
+ this(zkClient, clusterName, resources, expectLiveInstances, false);
+ }
+
+ private StrictMatchExternalViewVerifier(String zkAddr, String clusterName,
Set<String> resources,
+ Set<String> expectLiveInstances, boolean isDeactivatedNodeAware) {
super(zkAddr, clusterName);
_resources = resources;
_expectLiveInstances = expectLiveInstances;
+ _isDeactivatedNodeAware = isDeactivatedNodeAware;
}
- public StrictMatchExternalViewVerifier(HelixZkClient zkClient, String
clusterName,
- Set<String> resources, Set<String> expectLiveInstances) {
+ private StrictMatchExternalViewVerifier(HelixZkClient zkClient, String
clusterName,
Review comment:
I didn't quite get what you suggested. The current design is that this
constructor is only for builder to use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
