jiajunwang commented on a change in pull request #510: Fixing rebalance cache issue and stablize the tests. URL: https://github.com/apache/helix/pull/510#discussion_r335104513
########## File path: helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestMixedModeAutoRebalance.java ########## @@ -211,7 +211,6 @@ public void testUserDefinedPreferenceListsInFullAutoWithErrors() throws Exceptio } return false; }, 2000); - Assert.assertTrue(_clusterVerifier.verify(3000)); Review comment: Because we adjust the behavior of strict ev verifier again in this PR. Basically, change it back to verify based on the preference list. So it will never converge to mapping with ERROR state. Note that is changing the behavior back to fit the master branch code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org