jiajunwang commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337173051
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/metrics/WagedRebalancerMetricCollector.java
##########
@@ -38,7 +41,11 @@
// The following latency metrics are related to AssignmentMetadataStore
StateReadLatencyGauge,
- StateWriteLatencyGauge
+ StateWriteLatencyGauge,
+
+ // Count of any rebalance failure.
+ // Note the rebalancer may still be able to return an assignment based on
the previous record on an error.
Review comment:
The format file does not care about the comments, I guess. Is it
configurable?
I will fix it manually this time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
