jiajunwang commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337194743
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/metrics/WagedRebalancerMetricCollector.java
##########
@@ -66,15 +73,20 @@ private void createMetrics() {
WagedRebalancerMetricNames.GlobalBaselineCalcLatencyGauge.name(),
getResetIntervalInMs());
LatencyMetric partialRebalanceLatencyGauge = new RebalanceLatencyGauge(
WagedRebalancerMetricNames.PartialRebalanceLatencyGauge.name(),
getResetIntervalInMs());
- LatencyMetric stateReadLatencyGauge = new RebalanceLatencyGauge(
- WagedRebalancerMetricNames.StateReadLatencyGauge.name(),
getResetIntervalInMs());
- LatencyMetric stateWriteLatencyGauge = new RebalanceLatencyGauge(
- WagedRebalancerMetricNames.StateWriteLatencyGauge.name(),
getResetIntervalInMs());
+ LatencyMetric stateReadLatencyGauge =
+ new
RebalanceLatencyGauge(WagedRebalancerMetricNames.StateReadLatencyGauge.name(),
+ getResetIntervalInMs());
+ LatencyMetric stateWriteLatencyGauge =
+ new
RebalanceLatencyGauge(WagedRebalancerMetricNames.StateWriteLatencyGauge.name(),
+ getResetIntervalInMs());
Review comment:
Auto formatted according to the style template. It's always good to keep the
code style the same, and I have touched this file anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
