narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337799033
########## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java ########## @@ -69,6 +69,7 @@ // contains 1. baseline recalculate, 2. partial rebalance that is based on the new baseline. private static final Set<HelixConstants.ChangeType> GLOBAL_REBALANCE_REQUIRED_CHANGE_TYPES = Review comment: NIT: `CHANGE_TYPES_REQUIRING_GLOBAL_REBALANCE` would be correct technically. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
